[Yum-devel] [PATCH] Make Depsolve.check* generators instead of returning lists

Tim Lauridsen tim.lauridsen at googlemail.com
Wed May 21 10:47:32 UTC 2008


Florian Festi wrote:
> Hi!
> 
> As already announced on IRC I still have a pile of patches that were 
> waiting for the 4.0.x branch to open.
> 
> These two switch to using generators instead of lists for the 
> Depsolve.check* family. This allows us to restart the checking when ever 
> the transaction is changed. This will allow us to further simplify the 
> logic of the depsolver as we can be sure that the problem we are 
> currently trying to solve still exists.
> 
> Comments?
> 
> Florian
> 
>
The patches look good to me.
* Don't break any test (more than the failing already)
* Don't make yum slower.
* A simple test (time echo n | sudo yum install kde\*) gives the same 
result as before adding the patches.

Tim



More information about the Yum-devel mailing list