[Yum-devel] [RFC] return value of TransactionInfo.add*
Florian Festi
ffesti at redhat.com
Tue Jun 3 15:37:30 UTC 2008
seth vidal wrote:
> On Tue, 2008-05-27 at 17:46 +0200, Florian Festi wrote:
>
>> The attached patch tried to solve that by returning a dict with different
>> lists of txmbrs. This dict had to be requested by a special param because of
>> API compatibility. In general I don't like that solution much. We could now
>> make it the default to return something more meaning full. I also don't like
>> the idea of returning a dict very much. I currently think about greating a
>> new result class. This class could also offer methods like .modified(). The
>> result class should also be suited to be returned from YumBase.install(),
>> .update(), .remove() and friends. So we would need a way to collapse several
>> result objects into one.
>>
>> I don't have any code yet but want to ask what the general attitude towards
>> such a change is.
>
>
> +1 to having a class to do it
> -1 to a dict
> -1 to having a flag for api compat
>
> There's no point in lugging around older detritus, is there?
>
> -sv
Ok, so I am going to commit this as is. We can refine later on. The main
work will be to have a deeper look on what should actually be done with the
results. Right now I yum is just ignoring some of the added txmbrs. We need
to get an idea what to do with them.
Florian
More information about the Yum-devel
mailing list