[Yum-devel] [PATCH/RFC] Kill population

Florian Festi ffesti at redhat.com
Thu Jan 24 15:20:54 UTC 2008


Recent timings showed that we populate the transaction object several times. 
  This was necessary in the past when we where working with predownloaded 
headers but doesn't make sense anymore. I also realized that we call 
ts.check twice (once in _run_rpm_check_debug and once before ts.order).

The attached patch is the first step to get things into order again. It adds 
a .clearTsFlag() method to the Transaction object to set back the TEST flag 
and moves the _run_rpm_check_debug() call into the area where the 
.dsCallback is unset to get rid of the unsetting code in 
_run_rpm_check_debug() itself.

The code paths in cli.py look good already. The code in __init__.py - that 
is suposed to be used by 3rd party programs - is not that elaborated yet.

Can someone with a bit more "3rd party usage" experience look over the 
patch, please?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-population-the-transaction-object-over-and-ove.patch
Type: text/x-patch
Size: 6453 bytes
Desc: not available
Url : http://lists.baseurl.org/pipermail/yum-devel/attachments/20080124/e784ddbc/attachment.bin 

More information about the Yum-devel mailing list