[Yum-devel] [PATCH/RFC] tsInfo.getUnresolvedMembers()

[Florian Festi]

seth vidal wrote:
> On Thu, 2008-02-14 at 14:27 +0100, Tim Lauridsen wrote:
>> Florian Festi wrote:
>>> James Antill wrote:
>>>> On Wed, 2008-02-13 at 18:55 +0100, Florian Festi wrote:
>>>>> -        self.removedmembers = {}
>>>>> +        self._unresolvedMembers = set()
>>>> [...]
>>>>> -    def getRemovedMembers(self, pkgtup=None):
>>>>  These are both API changes, no?
>>> Sort of. Both were added in 3.2.3 and are only useful for the inner 
>>> depsolver loop (which is what I am altering here). No 3rd party should 
>>> be messing up with this. So any pain inflicted to those fiddling with 
>>> their own desolving loop is very welcome.
>>>
>>> If people feel better we can keep the method and variable. But I'd feel 
>>> better if we had an "exit strategy" to get rid of it some times in the 
>>> future.
>>>
>> +1, for just kill it.
>>
> 
> I'm a little worried the hash changes will get us into trouble, but I'd
> be okay w/giving it a try.

I'd even bet that the change will save us problems instead of causing them. 
Constructing equality for alterable objects is a really bad idea

Florian