[Yum-devel] [RFC/PATCH] Use REMOVE txmbr in _requiringFromInstalled
seth vidal
skvidal at fedoraproject.org
Thu Feb 14 14:12:35 UTC 2008
On Wed, 2008-02-13 at 14:06 +0100, Florian Festi wrote:
> Hi!
>
> I was wondering if _requiringFromInstalled couldn't be done easier if the
> REMOVE txmbr that is known in checkRemove is passed over. Attached is my
> first try to do this. The "if not remove_txmbr:" which more or less needs to
> do the same thing as the old code is probably a bit oversimplified (at least
> looping over all pkgs/txmbrs might be a good idea).
>
> Anyone an idea of what might get wrong?
This feels like a lot of code removal but not just for simplifying. I
think we're losing some nuance here. Additionally, we're losing A LOT of
debug output with your patches recently. That just makes it harder to
trace this out later. Consider adding some more debug log outputs.
-sv
More information about the Yum-devel
mailing list