[Yum-devel] Re: [yum-git] test/depsolvetests.py

Hans-Peter Jansen hpj at urpla.net
Tue Apr 1 12:45:10 UTC 2008


Am Dienstag, 1. April 2008 schrieb Tim Lauridsen:
> James Antill wrote:
> >  test/depsolvetests.py |   18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > New commits:
> > commit 07577aed00d900cdcf24ae60bf3006efe164cacc
> > Author: James Antill <james at and.org>
> > Date:   Mon Mar 31 18:14:10 2008 -0400
> >
> >     Arch vs. len doom testcase ... fun for skvidal
> >
> > diff --git a/test/depsolvetests.py b/test/depsolvetests.py
> > index 2629cf5..dc258ac 100644
> > --- a/test/depsolvetests.py
> > +++ b/test/depsolvetests.py
> > @@ -715,6 +715,24 @@ class DepsolveTests(DepsolveTests):
> >          self.assertEquals('ok', *self.resolveCode())
> >          self.assertResult((po, po2))
> >
> > +    def testCompareProviersArchVSLen(self):
                        ^^^^^^^^
> > +        po = FakePackage('abcd', arch='i386')
> > +        po.addRequires('foo', None, (None, None, None))
> > +        self.tsInfo.addInstall(po)
> > +
> > +        po1 = FakePackage('foo-bigger', arch='i686')
> > +        po1.addProvides('foo', None,(None,None,None))
> > +        po2 = FakePackage('foo-big', arch='i586')
> > +        po2.addProvides('foo', None,(None,None,None))
> > +        po3 = FakePackage('foo-xen', arch='i586')
> > +        po3.addProvides('foo', None,(None,None,None))
> > +        self.xsack.addPackage(po1)
> > +        self.xsack.addPackage(po2)
> > +        self.xsack.addPackage(po3)
> > +
> > +        self.assertEquals('ok', *self.resolveCode())
> > +        self.assertResult((po, po1))
> > +
> >      def testSelfObsInstall(self):
> >          xpo = FakePackage('abcd', version='2', arch='noarch')
> >          xpo.addObsoletes('abcd-Foo', None, (None, None, None))
> > _______________________________________________
> > https://lists.dulug.duke.edu/mailman/listinfo/yum-cvs-commits
>
> I think i would be a good idea to add docstring to new testcases, with
> notes about what we what to test with the current test, it makes it much
> easier to see what goes wrong, if some test starts to fail or what is
> needed to be worked out.

especially, if the method name is muddled up like this..

Pete



More information about the Yum-devel mailing list