[Yum-devel] Problem with depsolver goes into endless loop with big transaction of local packages

[Florian Festi]

Jeremy Katz wrote:
> On Thu, 2007-11-08 at 17:06 +0100, Terje Røsten wrote:
>> Jeremy Katz
>>> On Wed, 2007-11-07 at 20:01 +0100, Tim Lauridsen wrote:
>>>> I have created a patch for solving this issue.
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=360291
>>>>
>>>> Can anybody see any problems with the patch.
>>> Looks reasonable to me
>> We have  a test suite... And this patch don't break anything there.
> 
> Having a test suite only means that we know it doesn't break anything
> which we have a test for.  That's no substitute for reviewing changes
> and thinking about the intent and implications

While this is true in general I think we now reviewed that one line patch 
long enough...

Florian