[Yum-devel] 3.2

[James Bowes]

On Wed, 16 May 2007 16:11:37 -0400, Jeremy Katz wrote:
> On Wed, 2007-05-16 at 16:07 -0400, Jeremy Katz wrote:
> > On Wed, 2007-05-16 at 15:58 -0400, Jeremy Katz wrote:
> > > In some (light at this point) testing, everything seems to work but if I
> > > didn't break anything, I'll be shocked.  Thoughts, comments, other
> > > ideas?

I hate this bug.

> Index: output.py
> ===================================================================
> RCS file: /home/groups/yum/cvs/yum/output.py,v
> retrieving revision 1.76
> diff -u -u -r1.76 output.py
> --- output.py	21 Jan 2007 20:22:30 -0000	1.76
> +++ output.py	16 May 2007 20:11:13 -0000
> @@ -311,6 +311,7 @@
>      def setupProgessCallbacks(self):
>          """sets up the progress callbacks and various 
>             output bars based on debug level"""
> +        print "setupprogress"        
>  
>          # if we're below 2 on the debug level we don't need to be outputting
>          # progress bars - this is hacky - I'm open to other options
> @@ -332,6 +333,9 @@
>          # setup our depsolve progress callback
>          dscb = DepSolveProgressCallBack()
>          self.dsCallback = dscb
> +
> +        print "setupprogress done"
> +        
>              
>      def interrupt_callback(self, cbobj):
>          '''Handle CTRL-C's during downloads

Don't need this, eh?

> Index: yum/__init__.py
> ===================================================================
> RCS file: /home/groups/yum/cvs/yum/yum/__init__.py,v
> retrieving revision 1.326
> diff -u -u -r1.326 __init__.py
> --- yum/__init__.py	14 May 2007 18:39:58 -0000	1.326
> +++ yum/__init__.py	16 May 2007 20:11:13 -0000
> @@ -71,7 +71,7 @@
>          self._pkgSack = None
>          self.logger = logging.getLogger("yum.YumBase")
>          self.verbose_logger = logging.getLogger("yum.verbose.YumBase")
> -        self._repos = None
> +        self._repos = RepoStorage(self)
>  
>          # Start with plugins disabled
>          self.disablePlugins()

Could switch this back to self.repos now.

> Index: yum/repos.py
> ===================================================================
> RCS file: /home/groups/yum/cvs/yum/yum/repos.py,v
> retrieving revision 1.105
> diff -u -u -r1.105 repos.py
> --- yum/repos.py	25 Apr 2007 18:28:31 -0000	1.105
> +++ yum/repos.py	16 May 2007 20:11:13 -0000
> @@ -27,13 +27,39 @@
>      """This class contains multiple repositories and core configuration data
>         about them."""
>         
> -    def __init__(self):
> +    def __init__(self, ayum):

This breaks api, right? That's what bugs me, as we already know what the bug breaks, but not what the fix might break.

-James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.baseurl.org/pipermail/yum-devel/attachments/20070516/d806e12b/attachment.pgp