[Yum-devel] [PATCH/RFC] Don't exit immediately on lock held

[Jeremy Katz]

On Thu, 2007-07-26 at 10:53 -0400, seth vidal wrote:
> On Thu, 2007-07-26 at 10:45 -0400, Jeremy Katz wrote:
> > On Thu, 2007-07-26 at 10:41 -0400, Jeremy Katz wrote:
> > > Per a suggestion on fedora-devel-list from Hans de Goede, the following
> > > makes it so that we don't immediately exit on the command line if the
> > > lock is held by another process.  Instead, we spin checking every two
> > > seconds to see if the lock has been released.  This helps in the case
> > > where, eg, yum-updatesd is downloading metadata so that you don't have
> > > to guess when it's done.  And if you don't want to wait, ctrl-c exits
> > > immediately.
> > > 
> > > Other opinions/thoughts?
> > 
> > Seth thinks it helps when I actually attach the patch.  I can't
> > disagree.
>
> I'm going to say something I don't say all that much but:
> 1. maybe make the behavior an option - defaulting to on
>    or maybe make it so after 10 or 15 retries it drops out. so it
> doesn't just sit and spin forever.

Yeah, I had this thought.  The fact that you can ctrl-c out of it seemed
to make that maybe less important.  I could be swayed either way
probably.

> 2. the error message needs to be more verbose, 

Yeah.  But spending time on a good message if we didn't think it was a
good idea seemed wasteful

Jeremy