[Yum-devel] [PATCH] Eliminate redundant progress output
tla at rasmil.dk
Fri Jan 26 07:44:14 UTC 2007
seth vidal wrote:
> On Thu, 2007-01-25 at 16:47 -0800, Ed Swierk wrote:
>> yum 3.0.1 generates redundant progress output while installing
>> packages: rpm calls back into yum for every file it touches, which
>> causes yum to refresh the progress indicator even if neither the
>> percentage nor the hash marks have changed.
>> When installing a package with ~23000 files (a complete kernel source
>> tree), yum writes about 1.8 Mbytes to stdout. This is pretty painful
>> when SSHing over a slow link or even when working locally using a
>> fancy terminal like the xemacs shell.
>> The attached patch suppresses redundant progress updates but does not
>> otherwise alter any functionality. With the patch, yum generates only
>> 3756 bytes to stdout when installing the same package, a savings of
>> approximately 100% :-)
> Well the patch is pretty straightforward. I don't see any good reason
> not to include it. Anyone else see anything obviously wrong with it?
Looks fine to me.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Yum-devel