[Yum-devel] [PATCH] Profiling yum

Florian Festi ffesti at redhat.com
Tue Dec 18 09:14:15 UTC 2007


Tim Lauridsen wrote:
> Tim Lauridsen wrote:
>> Tim Lauridsen wrote:
>>> Florian Festi wrote:
>>>> Hi!
>>>>
>>>> The attached patch adds profiling to yummain.py. It's not that 
>>>> beautiful as it replaces all kind of system.exit() calls by returns. 
>>>> I don't like all these exit calls. But if anyone really likes them 
>>>> we can just catch the SystemExit exceptions...
>>>>
>>>
>>> The patches look fine to me.
>>>
>>>> I'd also like to add command line switch to enable profiling. May be 
>>>> --profile=(main|main-hot|depsolve|depsolve-hot|...)
>>>>
>>>
>>> I don't like adding the --profile= to the default yum cli the newest 
>>> yum-utils inherit the yum cli command line switches and the 
>>> --profile, will not work there and it also is to not use to the 
>>> normal yum user.
>>>
>>> what about making a special yumprof.py there is importing the main from
>>> yummain.py and run the selected profiler on the main imported from 
>>> yummain.py.
>>>
>>> Example:
>>> sudo ./yumprof.py (main|main-hot|depsolve|depsolve-hot|...) install 
>>> *.i386
>>>
>>> Tim
>>> _______________________________________________
>>> Yum-devel mailing list
>>> Yum-devel at linux.duke.edu
>>> https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
>>
>> Here is a patch to move the profile code to yumprof.py
>>
>> Comments please.
>>
>> Tim

> Any objections to committing the patch ?

Ehm, sorry. I was too much in other things...
Looks fine to me. May be we can find an even less prominent place to put the 
script to. But we should be fine with your patch for now.

Florian



More information about the Yum-devel mailing list