[Yum-devel] Re: [yum-cvs] yummain.py

[Tim Lauridsen]

seth vidal wrote:
> On Fri, 2007-12-14 at 05:10 -0500, Florian Festi wrote:
>> yummain.py |  110 +++++++++++++++++++++++++++++++++++++------------------------
>>  1 file changed, 67 insertions(+), 43 deletions(-)
>>
>> New commits:
>> commit 60b388ac8d47ae69bc7d60b23354272e8d70b4d1
>> Author: Florian Festi <ffesti at redhat.com>
>> Date:   Thu Dec 13 13:49:10 2007 +0100
>>
>>     Support profiling for yum as a whole
>>
> 
> 
> Florian,
>  Why did you check this in? I don't think we had finished discussing it.
> I don't like this 'email a patch on day 1, if no comments say NOOOOO
> then commit it' policy you seem to have taken up. I agree with what Tim
> said yesterday that there's no compelling reason to put this in yummain
> at all when we can, instead just create a separate yumprof.py which
> duplicates yummain.py which we can use for running the profiling
> routines instead.
> 
> -sv
> 

Seth, This patch mostly change the sys.exit to returm and have a central
sys.exit(return value), this part looks fine IMHO.
There is also, some not used profile funcs, this should be move to a 
separate file IMHO.

Tim