[Yum-devel] [PATCH] Fix for self obsoletes loop

[Panu Matilainen]

On Tue, 31 Jul 2007, seth vidal wrote:

> On Tue, 2007-07-31 at 15:28 -0400, James Antill wrote:
>> This patch skips over self obsoletes on packages (otherwise we get into
>> a horrible loop and die). It was written by Panu, but I merged it for RH
>> and I haven't seen him post it so...

Ah, I'd forgotten all about that. Thanks for posting.

>>
>>  I've attached it and it can be merged from:
>>
>> git pull http://people.redhat.com/jantill/gits/yum pkg-self-obsolete
>
> committed. thanks.
>
> oh and the git pull to merge b/t them is cool but getting rid of the
> changes was not terribly obvious. jbowes helped me get out of the mess I
> had made as a result.

Hey, please do "git-config --global merge.summary 1"
With that, you'll get meaningful changelog messages from pull-merges, the 
very terse default of "merge branch 'foo' of ..." doesn't tell anything 
about the actual changes that went in, and since those merges are 
typically from throwaway trees the info is likely to be gone forever.

Just for example, merge with yum-ffesti..

Default msg:

     Merge git://www.jur-linux.org/git-data/yum-ffesti

With the merge.summary setting (mail client messing up formatting but 
you'll get the idea):

     Merge git://www.jur-linux.org/git-data/yum-ffesti

     * git://www.jur-linux.org/git-data/yum-ffesti: (22 commits)
       merge resolveDeps patch
       remove merge artifact
       move creation of sqlite idices to sqlitesack to create them even if 
the me
       only search in sqlite db if there are any sqlitedb pkgs in the 
transaction
       fix copy/paste error: match new conflicts against whole transaction
       Add some test cases for rangeCompare
       Don't treat installed obsoletes as conflicts
       load PRCO only once from the sqlitedb - even if it is empty
       Make PackageSack.matchPackageNames() match all other implementations 
of th
       keep PackageSack indexes up2date
       remove code obsoleted by new search API
       trigger file requires check when install members got removed from 
transact
       Check removed transaction members to avoid missing dependencies
       Use new search API in checkRemove
       New conflict check implementation using new search API, fixes 
rh#245707
       use new search API in checkInstall
       ajust to new tsInfo interface
       add .get(Old|New)?Provides(), .get(Old|New)?Requires() to 
TransactionData
       add .getProvides(), .getRequires() to PackageSack, MetaSack
       add .getProvides(), .getRequires() to SqliteSack

 	- Panu -