[Yum-devel] more fun with config.RepoConf and YumRepo
Menno Smits
menno-yum at freshfoo.com
Fri Sep 29 15:45:52 UTC 2006
seth vidal wrote:
> On Fri, 2006-09-29 at 10:08 -0400, James Bowes wrote:
>> seth vidal wrote:
>>
>>>> I've had a look and it seems ok like this.
>>>>
>>>> To be honest, I don't see the point of self.setkeys. It looks
>>>> getAttribute supposed to return None if setAttribute hasn't been called
>>>> yet. Why not just set sensible defaults for the attributes at
>>>> initialization time? Why not use hasattr alone in getAttribute and be
>>>> done with it?
>>>>
>>> that's what I was thinking, too. However, that abstraction was added as
>>> a result of the rhn-work. I wonder if it has to do w/requesting
>>> attributes via xmlrpc.
>>>
>>> Hey - people working on rhn repos for yum - can you tell us what the
>>> hell?
>> self.setkeys was there before that first patch I sent in. So yeah, get
>> rid of it.
>>
>
> Ah ha. Then it must have been something stupid I did long ago.
It's gone. I got rid of a few unused methods relating to setkeys as well.
Menno
More information about the Yum-devel
mailing list