[Yum-devel] more fun with config.RepoConf and YumRepo

seth vidal skvidal at linux.duke.edu
Fri Sep 29 04:59:26 UTC 2006


On Fri, 2006-09-29 at 00:57 -0400, seth vidal wrote:
> A couple of more things have come out of this patch:
> 
> http://devel.linux.duke.edu/cgi-bin/viewcvs.cgi/yum/yum/yumRepo.py?r1=1.22&r2=1.23&diff_format=u
> 
> that was merged a couple of weeks back.
> 
> we seem to have lost access to most/all attributes that are referenced
> using the getAttribute() method of the repos.Repository class.
> 
> getAttribute() is this:
> 
>     def getAttribute(self, key):
>         if key in self.setkeys and hasattr(self, key):
>             return getattr(self, key)
>         return None
> 
> I'm thinking that the 'and' should be an 'or'
> 
> so if the key is in either of them then return it. Any idea on what
> situation we wouldn't want to return an attribute if it is set but not
> in self.setkeys?

Just so we know - I applied the above - but I'm not sure it is the
correct behavior.

-sv





More information about the Yum-devel mailing list