[Yum-devel] [patch] use basepath in URL resolution

Jeremy Katz katzj at redhat.com
Sun Oct 1 22:30:01 UTC 2006


On Sat, 2006-09-30 at 07:47 +0200, Tim Lauridsen wrote:
> Jeremy Katz wrote: 
> > On Fri, 2006-09-29 at 12:51 -0400, Dennis Gregorovic wrote:
> >   
> > > Currently, if the "xml:base" attribute of the "location" attribute is
> > > set in the package metadata, this causes "basepath" attribute of the
> > > corresponding package object to be set to that value.  The attached
> > > patch causes Yum to use this location when fetching the RPM and header.
> > >     
> > 
> > This looks pretty reasonable to me.  
> > 
> > We also should go through things in yum-utils and ensure that they're
> > doing the right thing -- it looks like there are a couple of utilities
> > that are just assuming they should use repo.urls[0] + relativepath.
> >   
> I just checked yumdownloader & reposync.
>
> they now uses the repo.getPackage() to download packages, so they dont
> supply the the full remote URL.

Matches what I saw

> If the '--urls' options is used then repo.urls[0] + relativepath is
> printed. 
> > Does it make sense to have YumAvailablePackage.remote_url as a property
> > which returns basepath/url + relativepath?
> >   
> It could be useful for printing the full remote URL, like done in the
> in the tools above.

*nod*  That's the use case I was basically thinking of -- anyone else
agree?

Jeremy




More information about the Yum-devel mailing list