[Yum-devel] RFC: [PATCH] Support showing full key url when importing

Jeremy Katz katzj at redhat.com
Fri Nov 17 14:07:44 UTC 2006


On Fri, 2006-11-17 at 02:19 -0500, seth vidal wrote:
> On Thu, 2006-11-16 at 14:24 -0500, Jeremy Katz wrote:
> > yuWhen importing a GPG key, it's probably a good idea to give some idea
> > of where it's being imported from.  Doing this for the cli is simple and
> > pretty non-controversial.  The question comes in for how to handle it
> > for API users as the callback API I put in isn't extensible :/
> > 
> > So, I'm going to propose adding a second callback type which _is_ more
> > extensible; patch attached.  This then lets people who want to use the
> > new API require yum 3.0.2 and have it or if not, then you can fallback
> > to the old style.  Thoughts?
> > 
> 
> the fullaskcb makes sense to me, especially for 3.0.x 

*nod*

>  however, for cvs
> head would it make sense to simply drop the less extensible one?

Realistically, I'd rather not just break things for the sake of breaking
things, even if it means that code sticks around for a long time and
isn't really used.  In some cases, sure, but it's not like keeping this
working is a big hit as far as maintenance or speed :)

Especially as the breakage would end up being subtle and not-noticed in
most cases

Jeremy




More information about the Yum-devel mailing list