[Yum-devel] [PATCH] code duplication reduction via excessive function pointers

[seth vidal]

On Mon, 2006-11-06 at 19:04 -0500, James Bowes wrote:
> Hi all:
> 
> Attached is a patch to reduce the duplication in sqlitecache.c in 
> yum-metadata-parser (specifically the update_primary, update_filelist 
> and update_other fuctions and their callbacks). In a nutshell, the code 
> that differs is pulled out into functions. The common code then calls 
> this code through function pointers stored in the UpdateInfo struct.
> 
> The patch was developed against HEAD + my patch for displaying the 
> repoid, so it won't apply cleanly to HEAD. If anyone would rather a 
> patch that doesn't require the repoid code, let me know and I'll write 
> that up.
> 

Your patch for the repoid fix should go in for the yum 3.0.2 and
associated release.

so - I don't see why not. :)

-sv