[Yum-devel] [urlgrabber] keepalive broken

Florian Festi ffesti at redhat.com
Thu Dec 7 13:24:00 UTC 2006


>> Looks like the "SSL patch to use M2Crypto when available" breaks 
>> keepalive. Problem is that fresh instances are inserted in to the 
>> handlers list. This lets CachedOpenerDirector() fail to find a 
>> matching opener. The attached patch fixes this problem by caching 
>> HTTPSHandlers by ca_cert, ssl_context.
> 
> oops. Nice catch, Florian :)

Thanks!

>> I also added calls to the __init__() methods of urllib2 super classes 
>> of HTTPHandler and HTTPSHandler.
> 
> IIRC, those were kept out intentionally, as calling them on python 2.3 
> broke things.

Oops...
I am on Python 2.4.

Florian



More information about the Yum-devel mailing list