[Yum-devel] Re: [yum-cvs] yum/yum packageSack.py, 1.6, 1.7 packages.py, 1.51, 1.52
seth vidal
skvidal at linux.duke.edu
Tue Aug 22 17:31:05 UTC 2006
On Tue, 2006-08-22 at 13:28 -0400, Jeremy Katz wrote:
> Style question only...
>
> On Tue, 2006-08-22 at 00:04 -0400, Seth Vidal wrote:
> > + def __lt__(self, other):
> > + val = False
> > + rc = comparePoEVR(self, other)
> > + if rc < 0:
> > + val = True
> > +
> > + return val
>
> Does it make more sense to do
> def __lt__(self, other):
> if comparePoEVR(self, other) < 0:
> return True
> return False
>
> instead? It's more compact and so a little easier for me to read, but I
> doubt it has any real effect beyond aesthetics.
>
I've always liked having my values broken out a bit for each of the
items I'm looking at - but I don't see any reason not to do it the other
way.
sometimes compact also == hard to read - but I see your point.
-sv
More information about the Yum-devel
mailing list