[Yum-devel] Re: [yum-cvs] yum/yum packageSack.py, 1.6, 1.7 packages.py, 1.51, 1.52

Jeremy Katz katzj at redhat.com
Tue Aug 22 17:28:04 UTC 2006


Style question only...

On Tue, 2006-08-22 at 00:04 -0400, Seth Vidal wrote:
> +    def __lt__(self, other):
> +        val = False
> +        rc = comparePoEVR(self, other)
> +        if rc < 0:
> +            val = True
> +        
> +        return val

Does it make more sense to do 
  def __lt__(self, other):
    if comparePoEVR(self, other) < 0:
       return True
    return False

instead?  It's more compact and so a little easier for me to read, but I
doubt it has any real effect beyond aesthetics.

Jeremy




More information about the Yum-devel mailing list