[Yum-devel] [Patch 4/4] Defining other repository types in yum

[pvetere at redhat.com]

Heh.  That would be me.  :-)  I worked with James on these patches.  
Looks like you found a line we missed when were cleaning up the code 
for submission.  I
commented out this line because we abstracted the RepoStorage class to 
a degree
where it no longer had specific knowledge of which repository was
sqlite-capable.  That knowledge now lives inside of the YumRepo class itself.

As I see it, the purpose of the code here is simply to warn the user 
when sqlite
is not available.  We could either move this code down into the YumRepo class
(and have that class warn the user) or provide an abstract accessor method in
the RepoStorage class which queries each of the repository types for their
sqlite-ness and then proxies that knowledge up to caller.

Pete


Quoting seth vidal <skvidal at linux.duke.edu>:

> Index: yum/__init__.py
> ===================================================================
> --- yum/__init__.py     (.../branches/vendor/yum)       (revision 51)
> +++ yum/__init__.py     (.../trunk/yum) (revision 51)
> @@ -60,8 +60,9 @@
>         depsolve.Depsolve.__init__(self)
>         self.localdbimported = 0
>         self.repos = repos.RepoStorage() # class of repositories
> -        if (not self.repos.sqlite):
> -            self.log(1,"Warning, could not load sqlite, falling back to
> pickle")
> +        # TODO: PAV Fix this
> +        #if (not self.repos.sqlite):
> +        #    self.log(1,"Warning, could not load sqlite, falling back
> to pickle")
>
>         # Start with plugins disabled
>         self.disablePlugins()
>
> Who is PAV and what is he fixing here?
>
> -sv
>