[Yum-devel] TODOs in sqlite code

Menno Smits menno-yum at freshfoo.com
Wed Mar 2 11:24:37 UTC 2005


seth vidal wrote:
> Looking over the todos in sqlitecache.py and some items in sqlitesack.py
> 
> 1. print statements: would it be worthwhile to pass in a slightly
> enhanced callback for the sqlite code? If we're going to break compat on
> how the callback is done we should do it now. I'm thinking a callback
> that includes:
>    callback.progressbar()
>    callback.errorlog()
>    callback.log()
>    callback.filelog()
>  would be worth passing into the cache parsing. I'm sure this would make
> the gui people happy, too. (right paul? :)
> 
> This will also give us the opportunity to possibly collapse all of our
> callbacks into output.py and clean up the odd places they currently
> exist.

This sounds great. I'm happy to have a go at this unless someone has 
started already.

>     1.5: there are 2 print statements in sqlitesack.py and I don't really 
>        know why they're there. They print one not-so-useful line of 
>        output. Does the sqlitesack code really need any print mechanism?

I think these prints can go. However if the sqlitesack code does need to 
print, the above callback will be available for this purpose (it'll get 
passed to addDict()).

Menno



More information about the Yum-devel mailing list