[Yum-devel] [PATCH] Some sqlite-fixes

Panu Matilainen pmatilai at welho.com
Tue Mar 1 21:07:38 UTC 2005


On Tue, 2005-03-01 at 21:42 +0100, Gijs Hollestelle wrote:
> On Tue, 01 Mar 2005 21:37:40 +0200, Panu Matilainen <pmatilai at welho.com> wrote:
> Hi Panu,
> 
> Thanks for your patch, it looks great I'll apply it to CVS as soon as
> I get the chance to try it out.

Cool.

> 
> > - add returnChangelog() method to the package objects so external code
> > doesn't need to specifically detect sqlite and call loadChangelog() for
> > it
> I didn't do this before because I did not want to change any of the
> non sqlite files. But this makes things alot easier.

I'd guess it was just a case of nothing in yum really using changelogs
so the method was never added. I think there were some similar cases
(not necessarily related to sqlite) I found but can't remember off the
top of my head what those were - will send more patches if/when I
encounter them again.

> 
> > - protect file- and other data from being loaded more than once
> > - sqlitesack.getChangelog() was rather broken: referring to
> > filelistsdb.items() and thus not finding anything at all, the keys are
> > missing table prefix causing the query to fail, and the return values of
> > that method was incompatible with the repomd changelog format (dict
> > instead of tuple)
> It appears that somehow the getChangelog stuff that is in CVS now is
> completly broken, while it has worked before. I suspect something went
> wrong when I moved from my own subversion repo to yum CVS.

Shit happens :) BTW I wouldn't mind at all having the changelog-stuff
returning dicts instead of tuples like the current cvs-head was trying
to do (I just hate tuples), but that'd need changing in the repomd
objects as well. Seth, thoughts?

	- Panu -




More information about the Yum-devel mailing list