[Yum-devel] [PATCH] report total download size

seth vidal skvidal at phy.duke.edu
Mon Jan 24 05:19:44 UTC 2005


On Sun, 2005-01-23 at 14:26 +0100, Gijs Hollestelle wrote:
> Hi all,
> 


A few small changes to your patch:

--- output.py   24 Jan 2005 05:13:41 -0000      1.44
+++ output.py   24 Jan 2005 05:15:18 -0000
@@ -343,11 +343,11 @@
                 totsize += size
             except:
                  error = True
-                 self.log(5, 'There was an error calculating total download size')
+                 self.errorlog(1, 'There was an error calculating total download size')
                  break

         if (not error):
-            print "Total download size: %s" % (self.format_number(totsize))
+            self.log(1, "Total download size: %s" % (self.format_number(totsize)))



1. output errors as errorlog entries - but this isn't a critical error
so only errorlevel 1
2. don't print it - output it as a level one log - so unless someone
wants to see this info - they won't see it every night in the cron
report :(

Otherwise, looks great and it has been merged, thanks!

-sv







More information about the Yum-devel mailing list