[Rpm-metadata] pylint patches for createrepo

[Tim Lauridsen]

Here is some patches to add pylint checks to createrepo and fixes the most common warnings.

use:
make pylint

or

make pylint-short

to check do the check (pylint-short shows only errors and warnings and no report in the end)

> $ make pylint-short
> ************* Module dmd
> F0401: 22: Unable to import 'lxml.etree.parse' (No module named lxml)
> F0401: 22: Unable to import 'lxml.etree.tostring' (No module named lxml)
> F0401: 22: Unable to import 'lxml.etree.Element' (No module named lxml)
> ************* Module modifyrepo
> E1103: 98:RepoMetadata.add: Instance of 'Document' has no 'firstChild' member (but some types could not be inferred)
> E1103:101:RepoMetadata.add: Instance of 'Document' has no 'firstChild' member (but some types could not be inferred)
> ************* Module createrepo
> E0203:633:MetaDataGenerator._get_old_package_dict: Access to member '_old_package_dict' before its definition line 635
> ************* Module createrepo.deltarpms
> E0602: 69:DeltaRPMPackage._getOldInfo: Undefined variable 'zlibError'

Here is the current output of errors, there needs to be dealt with.

Tim
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Added-the-pylint-basic-and-disabled-the-warning-we-d.patch
URL: <http://lists.baseurl.org/pipermail/rpm-metadata/attachments/20090421/f4f754c2/attachment.diff>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-pylint-fixed-Bad-indentation.patch
URL: <http://lists.baseurl.org/pipermail/rpm-metadata/attachments/20090421/f4f754c2/attachment-0001.diff>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-pylint-fixed-unused-imports.patch
URL: <http://lists.baseurl.org/pipermail/rpm-metadata/attachments/20090421/f4f754c2/attachment-0002.diff>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-pylint-fixed-Redefining-built-in.patch
URL: <http://lists.baseurl.org/pipermail/rpm-metadata/attachments/20090421/f4f754c2/attachment-0003.diff>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0005-pylint-fixed-Uses-of-a-deprecated-module-string.patch
URL: <http://lists.baseurl.org/pipermail/rpm-metadata/attachments/20090421/f4f754c2/attachment-0004.diff>